Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add required components keyword #2485

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Nov 11, 2024

SolaraViz now requires components to be a keyword argument, this adds it to the two example that didn't have that.

It also shows we really need to start testing our examples in CI.

SolaraViz now requires components to be a keyword argument, this adds it to the two example that didn't have that.
@EwoutH EwoutH added example Changes the examples or adds to them. backport-candidate PRs we might want to backport to an earlier branch labels Nov 11, 2024
@EwoutH EwoutH requested review from quaquel and Corvince November 11, 2024 11:39
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.7% [-1.8%, +3.1%] 🔵 +0.1% [-0.1%, +0.4%]
BoltzmannWealth large 🔵 -1.1% [-1.7%, -0.3%] 🔵 +0.1% [-1.5%, +1.4%]
Schelling small 🔵 -0.7% [-1.0%, -0.4%] 🔵 +0.2% [+0.0%, +0.4%]
Schelling large 🔵 -0.5% [-1.0%, -0.1%] 🔵 -1.8% [-3.4%, -0.2%]
WolfSheep small 🔵 -0.4% [-0.7%, +0.0%] 🔵 -0.4% [-0.6%, -0.2%]
WolfSheep large 🔵 -1.1% [-1.9%, -0.3%] 🔵 -3.2% [-5.1%, -1.1%]
BoidFlockers small 🔵 +1.5% [+1.1%, +1.8%] 🔵 +0.6% [+0.0%, +1.3%]
BoidFlockers large 🔵 +1.8% [+1.5%, +2.1%] 🔵 +1.1% [+0.5%, +1.6%]

@EwoutH EwoutH merged commit 544b735 into projectmesa:main Nov 11, 2024
13 of 14 checks passed
EwoutH added a commit that referenced this pull request Nov 11, 2024
SolaraViz now requires components to be a keyword argument, this adds it to the two example that didn't have that.
@Corvince
Copy link
Contributor

I think a better solution would be to just make it non-required keyword anymore!? I think its more natural to have solaraviz(model, components). These are always required (without components it doesnt make a lot of sense)

@EwoutH
Copy link
Member Author

EwoutH commented Nov 11, 2024

I'm good with that, I mainly just want working examples 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate PRs we might want to backport to an earlier branch example Changes the examples or adds to them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants