-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added empty iterable checks and updated tests #2523
Conversation
Performance benchmarks:
|
Hey @quaquel can you please review the changes for this pull request. |
This is a part of the code base that I am not intimately familiar with, so I need some more time. I hope to get to it somewhere in the coming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, this is indeed an useful edge-case to catch.
Having your first PR go through without any review comments is something that doesn't happen that often, great work. |
Thanks @EwoutH, I just happened to be familiar with code. |
## Summary Fixed the handling of empty iterables in _make_model_kwargs. Now raises a ValueError when an empty list is passed. ## Bug / Issue Empty iterables weren't properly handled. ## Implementation Updated `_make_model_kwargs` to raise a ValueError for empty iterables. added a new function `test_batch_run_with_params_with_empty_content()` for testing.
Summary
Fixed the handling of empty iterables in _make_model_kwargs. Now raises a ValueError when an empty list is passed.
Bug / Issue
Closes #2108.
Empty iterables weren't properly handled.
Implementation
Updated
_make_model_kwargs
to raise a ValueError for empty iterables.added a new function
test_batch_run_with_params_with_empty_content()
for testing.