Make cel-java work in Graal native images #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: includes a commit from #22 |
|
/cc @nastra |
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
============================================
+ Coverage 79.73% 79.75% +0.01%
- Complexity 1665 1670 +5
============================================
Files 89 91 +2
Lines 7388 7394 +6
Branches 1085 1084 -1
============================================
+ Hits 5891 5897 +6
Misses 1001 1001
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
thanks for the ping. will test+review tomorrow |
Introduces a Gradle plugin to scan the compiled classes and configuration-dependencies for classes that require an entry in `reflection-config.json`. With the generated `reflection-config.json` + `native-image.properties` the Graal `native-image` tool has enough information to allow reflection for google-protobuf generated files.
nastra
approved these changes
Jun 25, 2021
|
|
||
| package org.projectnessie.cel.tools.plugins | ||
|
|
||
| import org.gradle.api.Project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach to make cel-java work in Graal native image files is to generate Graal native image meta files.
Introduces a Gradle plugin to scan the compiled classes and configuration-dependencies for classes that require an entry in
reflection-config.json.With the generated
reflection-config.json+native-image.propertiesthe Graalnative-imagetool has enough information to allow reflection for google-protobuf generated files.Splits the
generatedproject intogenerated-pb, which contains only the generated Java files for protobuf, andgenerated-antlr, which only contains the generated Java files for the CEL parser.