Relocate antlr-runtime #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=========================================
Coverage 79.92% 79.92%
Complexity 1753 1753
=========================================
Files 97 97
Lines 7611 7611
Branches 1117 1117
=========================================
Hits 6083 6083
Misses 1021 1021
Partials 507 507
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
omarsmak
reviewed
Nov 2, 2021
generated-antlr/build.gradle.kts
Outdated
| dependencies { | ||
| include(dependency("org.antlr:antlr4-runtime")) | ||
| } | ||
| relocate("org.antlr.v4.runtime", "org.projectnessie.cel.parser.gen.antlr.v4.runtime") |
There was a problem hiding this comment.
Does it make sense if we keep the shaded package name as it is and add shaded prefix (something similar to Iceberg)? e.g: org.projectnessie.cel.shaded.org.antlr.v4.runtime. In order to distinguish that is shaded from org.antlr.v4.runtime
There was a problem hiding this comment.
Yup - updated the package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52