Carly Burkhart - Completed Project #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmicek
reviewed
Aug 26, 2023
| summary: Add to Cart | ||
| description: Add a product to the users cart | ||
| tags: | ||
| - addToCart |
There was a problem hiding this comment.
might be better to just have everything cart related under the tag of Cart
| summary: Sunglasses from a specific brand | ||
| description: displays products from a specific brand | ||
| tags: | ||
| - brand id |
| var queryString = require('querystring') | ||
| var Router = require('router') | ||
| var bodyParser = require('body-parser') | ||
| var uid = require('rand-token').uid | ||
|
|
There was a problem hiding this comment.
Would add in const path = require("path");
| server.listen(PORT, () => { | ||
| // Load brands data | ||
| brands = JSON.parse(fs.readFileSync('../initial-data/brands.json', 'utf-8')) |
There was a problem hiding this comment.
would recommend using path like this
brands = JSON.parse(fs.readFileSync(path.resolve(__dirname, '../initial-data/brands.json'), 'utf-8'))
| @@ -11,10 +11,16 @@ | |||
| "license": "ISC", | |||
There was a problem hiding this comment.
under scripts you could add one for test and instead of node you do mocha .\app\server-test
| var bodyParser = require('body-parser'); | ||
| var uid = require('rand-token').uid; | ||
| var http = require('http') | ||
| var fs = require('fs') |
There was a problem hiding this comment.
Stay consistent with variable declaration instead of switching between var and let/const
|
|
||
| http.createServer(function (request, response) { | ||
| // Variables | ||
| let brands = [] //list of all brands from json file |
There was a problem hiding this comment.
Try to remember to add semi-colons at the end of the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.