Rename ServiceMonitors so they don't get deleted by operator #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/service-monitors
branch
2 times, most recently
from
7038de9
to
00d3d15
Compare
We create our own ServiceMonitor resources, since the argocd-operator doesn't support creating ServiceMonitors without also deploying a Prometheus instance. However, the operator will delete any ServiceMonitor which matches the name that it would generate for its managed ServiceMonitors if the Prometheus component is disabled, cf. https://github.com/argoproj-labs/argocd-operator/blob/17064c9b310785ab145747a367f7deb5507a572e/controllers/argocd/prometheus.go#L129-L136 This causes the component-managed ServiceMonitors to get deleted from time to time, and they get recreated after a while by an ArgoCD resync. This commit circumvents the issue by renaming the component-managed ServiceMonitors so they don't get deleted by the operator.
simu
force-pushed
the
fix/service-monitors
branch
from
00d3d15
to
6cd258e
Compare
haasad
approved these changes
Nov 17, 2023
simu
added a commit
that referenced
this pull request
Nov 22, 2023
We renamed the ServiceMonitors in #129 without verifying that the renamed service monitors still discover any endpoints. We need to split the ServiceMonitor name from the name used for the label selector to ensure that we can use an object name which doesn't collide with the operator-managed name, while still picking up the endpoints.
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create our own ServiceMonitor resources, since the argocd-operator doesn't support creating ServiceMonitors without also deploying a Prometheus instance.
However, the operator will delete any ServiceMonitor which matches the name that it would generate for its managed ServiceMonitors if the Prometheus component is disabled, cf. https://github.com/argoproj-labs/argocd-operator/blob/17064c9b310785ab145747a367f7deb5507a572e/controllers/argocd/prometheus.go#L129-L136
This causes the component-managed ServiceMonitors to get deleted from time to time, and they get recreated after a while by an ArgoCD resync.
This commit circumvents the issue by renaming the component-managed ServiceMonitors so they don't get deleted by the operator.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.