Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acme-dns script permissions ug+rwx #104

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

simu
Copy link
Member

@simu simu commented Sep 16, 2022

This is required for OCP 4.11, as otherwise the job pod (which runs with an arbitrary UID/GID) can't execute the script, as the ConfigMap is mounted with owner root and group matching the pod's GID.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu force-pushed the fix/acme-dns-script-permissions branch from ad93b0b to ff66935 Compare September 16, 2022 13:43
@simu simu added the bug Something isn't working label Sep 16, 2022
@simu simu marked this pull request as ready for review September 16, 2022 13:43
@simu simu requested a review from a team as a code owner September 16, 2022 13:43
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

component/acme-dns.libsonnet Outdated Show resolved Hide resolved
This is required for OCP 4.11, as otherwise the job pod (which runs with
an arbitrary UID/GID) can't execute the script, as the ConfigMap is
mounted with owner root and group matching the pod's GID.
@simu simu force-pushed the fix/acme-dns-script-permissions branch from ff66935 to 34a9b8d Compare September 16, 2022 14:07
@simu simu merged commit 9c76c5c into master Sep 16, 2022
@simu simu deleted the fix/acme-dns-script-permissions branch September 16, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants