Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage OpenShift's kube-proxy deployment based on the value of kubeProxyReplacement #119

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jul 9, 2024

To ensure that the kube-proxy is deployed correctly if users switch back to kubeProxyReplacement=false we always deploy the Patch resource to configure the network.operator.openshift.io/cluster resource.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu added the enhancement New feature or request label Jul 9, 2024
@simu simu force-pushed the feat/disable-kube-proxy branch 2 times, most recently from 7443b1a to 1942169 Compare July 9, 2024 08:31
@simu simu marked this pull request as ready for review July 9, 2024 08:32
@simu simu requested a review from a team July 9, 2024 08:33
@simu simu changed the title Ensure that OpenShift doesn't deploy kube-proxy when kubeProxyReplacement=true/strict Manage OpenShift's kube-proxy deployment based on the value of kubeProxyReplacement Jul 9, 2024
simu added 4 commits July 9, 2024 10:41
…ement=true/strict`

To ensure that the kube-proxy is deployed correctly if users switch back
to `kubeProxyReplacement=false` we always deploy the Patch resource to
configure the `network.operator.openshift.io/cluster` resource.
Rendered from template version: main (2ae1bc3)
@simu simu force-pushed the feat/disable-kube-proxy branch from 1942169 to c480422 Compare July 9, 2024 08:41
@simu simu merged commit bbbf07f into master Jul 9, 2024
17 checks passed
@simu simu deleted the feat/disable-kube-proxy branch July 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants