Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deploying CiliumL2AnnouncementPolicies #129

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Aug 14, 2024

L2 Announcements is a feature which makes services visible and reachable on the local area network. This feature is primarily intended for on-premises deployments within networks without BGP based routing.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Aug 14, 2024
@DebakelOrakel DebakelOrakel requested a review from a team August 14, 2024 09:20
@DebakelOrakel DebakelOrakel force-pushed the feat/support-l2-announcements branch 5 times, most recently from f03d7f7 to 579716b Compare August 15, 2024 06:30
L2 Announcements is a feature which makes services visible and reachable on the local area network.
This feature is primarily intended for on-premises deployments within networks without BGP based routing.
@DebakelOrakel DebakelOrakel force-pushed the feat/support-l2-announcements branch from 579716b to 8cd1b27 Compare August 15, 2024 06:31
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

class/defaults.yml Show resolved Hide resolved
@DebakelOrakel DebakelOrakel force-pushed the feat/support-l2-announcements branch from 7c5d65f to 7593212 Compare August 15, 2024 08:17
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@DebakelOrakel DebakelOrakel force-pushed the feat/support-l2-announcements branch from 7593212 to d824a19 Compare August 15, 2024 08:22
Copy link

github-actions bot commented Aug 15, 2024

🚀 This PR has been released as v1.9.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@DebakelOrakel DebakelOrakel merged commit 3b5bc86 into master Aug 15, 2024
20 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/support-l2-announcements branch August 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants