Upgrade Rook to 1.11.11 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
deps/rook-1.11
branch
2 times, most recently
from
4cef1bb
to
4b377a2
Compare
simu
force-pushed
the
deps/rook-1.11
branch
3 times, most recently
from
568ba34
to
3820edb
Compare
Remove configuration for removed machine disruption config on OCP
DebakelOrakel
force-pushed
the
deps/rook-1.11
branch
from
3820edb
to
df22d42
Compare
simu
commented
Nov 1, 2023
There was a problem hiding this comment.
Please go over the runbooks again. The PR currently significantly reduces runbook quality:
Overall guidelines:
- Don't blindly commit the output of the runbook generator
- Label templates have no place in the runbook
- Compare changes carefully and think about what you'd like to see when you click on the runbook link in an alert, it's totally ok to rewrite the alert message to go more into the "why" of the alert instead of replicating the "what" from the alert description.
docs/modules/ROOT/pages/runbooks/CephMgrPrometheusModuleInactive.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/runbooks/CephMgrPrometheusModuleInactive.adoc
Outdated
Show resolved
Hide resolved
simu
commented
Nov 1, 2023
DebakelOrakel
force-pushed
the
deps/rook-1.11
branch
from
36731a1
to
7743d5d
Compare
DebakelOrakel
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #115
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.