Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete broken SCC manifest generated by Helm chart as postprocessing filter #140

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

simu
Copy link
Member

@simu simu commented Nov 15, 2023

Using Kapitan's remove input breaks catalog compilation with --local --no-fetch-dependencies, since the remove command still can't gracefully handle files which don't exist.

See also #115

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

…filter

Using Kapitan's `remove` input breaks catalog compilation with `--local
--no-fetch-dependencies`, since the remove command still can't
gracefully handle files which don't exist.
@simu simu added the bug Something isn't working label Nov 15, 2023
@simu simu requested a review from a team November 15, 2023 16:12
@simu simu merged commit 78c21d9 into master Nov 17, 2023
10 checks passed
@simu simu deleted the fix/local-compile branch November 17, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants