Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for monitor healthcheck #156

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Set default value for monitor healthcheck #156

merged 1 commit into from
Apr 23, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Apr 23, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the bug Something isn't working label Apr 23, 2024
@DebakelOrakel DebakelOrakel linked an issue Apr 23, 2024 that may be closed by this pull request
Rook incorrectly creates new MON deployments during maintenance #105
Closed
@DebakelOrakel DebakelOrakel mentioned this pull request Apr 23, 2024
Merged
@DebakelOrakel DebakelOrakel requested a review from a team April 23, 2024 07:33
@DebakelOrakel
Copy link
Contributor Author

Thinking about setting the other healthCheck parameters as well 🤔

simu
simu approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about setting the other healthCheck parameters as well

I was considering this as well, but I think just setting the MON health checks explicitly is good enough for now.

@DebakelOrakel DebakelOrakel merged commit c3af941 into master Apr 23, 2024
10 checks passed
@DebakelOrakel DebakelOrakel deleted the fix/default-mon-healthcheck branch April 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rook incorrectly creates new MON deployments during maintenance
2 participants
@DebakelOrakel @simu