Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rook v1.14: Document upgrade process to component v8 #160

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Apr 23, 2024

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan added the documentation Improvements or additions to documentation label Apr 23, 2024
@bastjan bastjan requested a review from a team April 23, 2024 16:43
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

IMO it's not necessary to have a fully working drain command here, but I'd definitely make the step explicit.

docs/modules/ROOT/pages/how-tos/upgrade-v7-v8.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/upgrade-v7-v8.adoc Outdated Show resolved Hide resolved
bastjan and others added 2 commits April 24, 2024 11:41
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@bastjan bastjan merged commit 1215af3 into master Apr 24, 2024
10 checks passed
@bastjan bastjan deleted the upgrade-docs-v8 branch April 24, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants