wrong colors for html

[slavamak]

Hey there! I like the github light default theme, but some of the colors don't match. This is what it should look like:

<ul hidden>
  <li id="a11y-new-window-message"></li>
</ul>

<script>
  window.routes = {
    cart_add_url: 'add',
    cart_change_url: 'change',
    cart_update_url: 'update',
  }
</script>

I'm trying to override the colors, but it doesn't seem to work

overrides = function(c)
  return {
    htmlArg = { fg = c.blue },
    htmlSpecialTagName = { fg = c.green },
  }
end

Maybe I'm doing something wrong? Any ideas
I use neovim 8.0, nvim-treesitier

[ful1e5]

Only a few highlights have been defined for Html in this theme, but the highlights aren't always the same due to constant changes in the treesitter. But still, you can override the highlights not already defined in this theme by enabling dev mode.

require('github-theme').setup({
  -- ...
  overrides = function(_)
    return {
    htmlArg = { fg = c.blue },
    htmlSpecialTagName = { fg = c.green },
    }
  end,
  dev = true,
})

[slavamak]

yes thanks, it seems to work. But still I can't override some things, like operators or semicolon.
Is this a treesitter problem or is this something that can be fixed with the theme?

[tmillr]

@slavamak it has been some months since this was originally posted, but just letting you know that alot of these issues have been fixed now and all you should need to do is update the plugin

[slavamak]

yeah, it seems to work good, thanks!