-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect syntax highlighting #259
Merged
Merged
Commits on Jun 2, 2023
-
fix: remove redundant highlight-group links
Comment-out several redundant hl-group links in: - lua/github-theme/group/syntax.lua - lua/github-theme/group/modules/treesitter.lua These are redundant because they specify links which are identical to Neovim defaults (e.g. `@string --> String`, `@function.call --> @function`, etc.). They are mimicking default links that Neovim already ships and starts-up with. Colorschemes may break Neovim's default links arbitrarily, and `:hi clear` restores them. Since we don't know if/which default links have been broken by the previous colorscheme when loading ours, we should restore these default links—either with `:hi clear`, or manually—before ours is loaded. This already appears to be happening within compiled colorschemes (i.e. `hi clear` gets embedded within them). Furthermore, colorscheme compilation happens automatically by default and cannot be disabled.
Configuration menu - View commit details
-
Copy full SHA for f6cd84f - Browse repository at this point
Copy the full SHA f6cd84fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a82dc33 - Browse repository at this point
Copy the full SHA a82dc33View commit details -
fix: incorrect syntax highlighting
Syntax highlighting is still not 100% accurate (due mostly to highlighting differences between different languages which require particular consideration), however, the accuracy of the highlights have been improved, both overall, and in terms of common languages such as: rust, ruby, ecma, c, c#, go, html, css, make, python, and lua. See projekt0n#252
Configuration menu - View commit details
-
Copy full SHA for 28266d4 - Browse repository at this point
Copy the full SHA 28266d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b68fc0 - Browse repository at this point
Copy the full SHA 5b68fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82bb16b - Browse repository at this point
Copy the full SHA 82bb16bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b34d00d - Browse repository at this point
Copy the full SHA b34d00dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e550f - Browse repository at this point
Copy the full SHA 85e550fView commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb601d8 - Browse repository at this point
Copy the full SHA cb601d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.