Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect syntax highlighting #259

Merged
merged 8 commits into from
Jun 18, 2023

Commits on Jun 2, 2023

  1. fix: remove redundant highlight-group links

    Comment-out several redundant hl-group links in:
    
    - lua/github-theme/group/syntax.lua
    - lua/github-theme/group/modules/treesitter.lua
    
    These are redundant because they specify links which are identical to
    Neovim defaults (e.g. `@string --> String`, `@function.call -->
    @function`, etc.). They are mimicking default links that Neovim already
    ships and starts-up with.
    
    Colorschemes may break Neovim's default links arbitrarily, and `:hi clear`
    restores them. Since we don't know if/which default links have been
    broken by the previous colorscheme when loading ours, we should restore
    these default links—either with `:hi clear`, or manually—before ours is
    loaded. This already appears to be happening within compiled
    colorschemes (i.e. `hi clear` gets embedded within them). Furthermore,
    colorscheme compilation happens automatically by default and cannot be
    disabled.
    tmillr committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f6cd84f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a82dc33 View commit details
    Browse the repository at this point in the history
  3. fix: incorrect syntax highlighting

    Syntax highlighting is still not 100% accurate (due mostly to
    highlighting differences between different languages which require
    particular consideration), however, the accuracy of the highlights have
    been improved, both overall, and in terms of common languages such as:
    rust, ruby, ecma, c, c#, go, html, css, make, python, and lua.
    
    See projekt0n#252
    tmillr committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    28266d4 View commit details
    Browse the repository at this point in the history
  4. fix: bash syntax highlighting

    tmillr committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    5b68fc0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    82bb16b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b34d00d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    85e550f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    cb601d8 View commit details
    Browse the repository at this point in the history