Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(update-colors): install stylua before using it #265

Merged
merged 1 commit into from
May 28, 2023

Conversation

tmillr
Copy link
Member

@tmillr tmillr commented May 28, 2023

Problem: the workflow is failing because run: make fmt invokes stylua,
and stylua is not available within ci by default.

Solution: use the action JohnnyMorganz/stylua-action@v3 to install and
invoke stylua instead of just doing run: make fmt.

See https://github.com/projekt0n/github-nvim-theme/actions/runs/5094439816/jobs/9158251649#step:6:13

@tmillr tmillr marked this pull request as draft May 28, 2023 02:14
Problem:  the workflow is failing because `run: make fmt` invokes stylua,
          and stylua is not available within ci by default.

Solution: use the action `JohnnyMorganz/stylua-action@v3` to install and
          invoke stylua instead of just doing `run: make fmt`.
@tmillr tmillr marked this pull request as ready for review May 28, 2023 02:22
@tmillr
Copy link
Member Author

tmillr commented May 28, 2023

Hopefully we can get this integrated once and for all lol. Sorry for the mishaps!

@tmillr tmillr mentioned this pull request May 28, 2023
9 tasks
@ful1e5 ful1e5 merged commit 5a3ce78 into projekt0n:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants