fix(syntax-hl): set nocombine on Comment
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `Comment`, don't inherit style attributes (e.g. bold, italic) from other (e.g. overlayed) hl groups. For example, an inline-comment appearing after a markdown heading in a markdown file (heading highlighting extends to the end of the text line, including comments) can become/display bold due to inheriting style attributes. `nocombine` keeps this from happening.
tmillr
force-pushed
the
fix-incorrect-highlights
branch
from
32f198f
to
ac071e0
Compare
Before and after (markdown heading)Before
After
|
ful1e5
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Comment, don't inherit style attributes (e.g. bold, italic) from other (e.g. overlayed) hl groups. For example, an inline-comment appearing after a markdown heading in a markdown file (heading highlighting extends to the end of the text line, including comments) can become/display bold due to inheriting style attributes.nocombinekeeps this from happening.