Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change Directory highlight group to be blue #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vqvw
Copy link

@vqvw vqvw commented Jul 11, 2024

This is a small PR, just to make the Directory highlight group blue. Only a suggestion. The reasoning behind this is to match the colour of directories in the light theme on Github:

image

Here is how it looks:

image

I also tried with gray since this is the colour of the directories in Github's dark theme, but it doesn't look quite as good:

image

Either way, the existing pink colour seems to be a little out of place, in my opinion at least.

@vqvw vqvw changed the title feat: change Directory hyi feat: change Directory highlight group to be blue Jul 11, 2024
@tmillr
Copy link
Member

tmillr commented Jul 12, 2024

Thanks for the pr and for pointing this out. Might have to give it some thought on what the default should be here. The Directory hl group is primarily meant for directory names, and it's not totally clear if it should apply to directory icons as well. In the wild it seems that some plugins use it for the icon (or rather the icon as well), while others do not (e.g. diffview.nvim). Either way, you're probably right in that it could use a better default. We also have the primitive that is used for (just) the icon on GitHub (e.g. require('github-theme.palette.primitives.light').treeViewItem.directory.fill), but then we're back to square one and it will get used for directory names too as your images demonstrate.

Which plugin is that from?

@vqvw
Copy link
Author

vqvw commented Jul 12, 2024

Hm, good point. The plugin from the screenshots is oil.nvim, which seems to use Directory for both the directory icon and directory names, but not file names.

@tmillr tmillr added the enhancement New feature or request label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants