fix(compiler): consider entire config when hashing #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
changed the title
tmillr
force-pushed
the
fix-compiler
branch
5 times, most recently
from
9360a34
to
6825feb
Compare
- Hash entire config instead of just the table passed to `setup()`. This
helps to ensure that a recompilation occurs when overrides are set
outside of `setup()`.
- Loading/sourcing colorscheme now causes recompilation if config or
overrides have changed, even if `setup()` has been called before.
- Clear `vim.g.colors_name` before setting `vim.o.background` so that
colorscheme is not reloaded recursively when setting
`vim.o.background` (as opposed to using a variable to check for nested
colorscheme load, which is what we were doing before).
- fix(compiler): always write hash to filesystem when a compilation
occurs, incl. when `require('github-theme').compile()` is called
directly.
Related: projekt0n#262, projekt0n#340, projekt0n#341
Please enter the commit message for your changes. Lines starting
th '%' will be ignored, and an empty message aborts the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash entire config instead of just the table passed to
setup(). This helps to ensure that a re-compile occurs when overrides are set outside ofsetup().Loading/sourcing colorscheme now causes recompilation if config or overrides have changed, even if
setup()has been called before.Clear
vim.g.colors_namebefore settingvim.o.backgroundso that colorscheme is not reloaded recursively when settingvim.o.background(as opposed to using a variable to check for nested colorscheme load, which is what we were doing before).fix(compiler): always write hash to filesystem whenever a compilation occurs, incl. when
require('github-theme').compile()is called directly.Related: #262, #340, #341