Fix race #1
Open
Fix race #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prev_offset is read by all worker threads and written by the thread with id 0 with the assumption that the new value will not be used by the other threads. This is however not enforced in any way and so worker threads with id != 0 might use the update value of prev_offset erroneously.
|
Jeez, I haven't really touched this since 2014, apparently. I will need to find some free time to look at the code and review the fix. Did you find some use for squashdelta? |
|
Yes, as part of a solution to send small updates to a resource constrained device. In this regard, I would like to retrieve the maximum size of the intermediate file when the merge operation is executed. Looking into the squashdelta implementation for that, but maybe you have some suggestion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prev_offset is read by all worker threads and written by the thread with id 0 with the
assumption that the new value will not be used by the other threads. This is however not
enforced in any way and so worker threads with id != 0 might use the update value of prev_offset
erroneously.