perf: remove redundant covariance computations

prokolyvakis · Nov 10, 2023 · 9006301 · 9006301
1 parent 48a6bec
commit 9006301
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/mudpod/misc.py b/mudpod/misc.py
@@ -38,12 +38,11 @@ def compute(self, arr: np.ndarray, o: np.ndarray, a: float) -> np.ndarray:
         Returns:
             The distances with respect to the observer `o`.
         """
-        def dist(x: np.ndarray) -> float:
-            if self.dtype == 'euclidean':
-                return euclidean(x, o)
-            if self.dtype == 'mahalanobis':
-                c = np.cov(arr.T)
-                return mahalanobis(x, o, c)
+        if self.dtype == 'euclidean':
+            dist = lambda x: euclidean(x, o)
+        else:
+            c = np.cov(arr.T)
+            dist = lambda x: mahalanobis(x, o, c)
 
         ds = np.apply_along_axis(
             dist,