[prometheus-postgres-exporter] trimmed data_source_uri if no extra options are provided #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re provided Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
zanhsieh
approved these changes
Mar 11, 2022
Zempashi
pushed a commit
to Zempashi/prometheus-helm-charts
that referenced
this pull request
Mar 16, 2022
…ty#1865) * Enable chart upgrades Fixed helm/charts#1726 * Bump chart version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If
.Values.config.datasource.extraParamsis not configured during the upgrade the URI will end with&.Special notes for your reviewer:
Despite not being an issue for the connection I find it cleaner to strip it out of the connection string.
Checklist
[prometheus-couchdb-exporter])