[prometheus] Enable pulling images by digest #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com>
Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com>
ivyostosh
requested review from
gianrubio,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
monotek
requested changes
Dec 23, 2022
Signed-off-by: MH <zanhsieh@gmail.com>
monotek
requested changes
Dec 24, 2022
Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com>
Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com>
Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com>
monotek
requested changes
Dec 25, 2022
Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com>
@monotek Updated! |
monotek
approved these changes
Dec 25, 2022
zanhsieh
approved these changes
Dec 25, 2022
cx-asafd
pushed a commit
to CheckmarxDev/prometheus-helm-charts
that referenced
this pull request
Dec 29, 2022
* [prometheus] Enable pulling images by digest Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> * [prometheus] Update helm chart version Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> * Update charts/prometheus/values.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update charts/prometheus/values.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update charts/prometheus/Chart.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update prometheus chart version Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> Signed-off-by: MH <zanhsieh@gmail.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
9 tasks
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 16, 2023
* [prometheus] Enable pulling images by digest Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> * [prometheus] Update helm chart version Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> * Update charts/prometheus/values.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update charts/prometheus/values.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update charts/prometheus/Chart.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> * Update prometheus chart version Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> Signed-off-by: Ostosh, Ivy <ivyjin215@gmail.com> Signed-off-by: MH <zanhsieh@gmail.com> Signed-off-by: Ivy Ostosh <ivyjin215@gmail.com> Co-authored-by: MH <zanhsieh@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Pulling images by digest allows users to “pin” an image to that version, and guarantee that the image is always the same (read more). This is not currently supported by the helm chart.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])