[kube-prometheus-stack] Add permission to the alertmanagers/status resource #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiden
requested review from
andrewgkew,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
twiden
changed the title
twiden
force-pushed
the
patch-1
branch
2 times, most recently
from
621393f
to
871b898
Compare
3 tasks
|
thanks for this fix @twiden - i've just seen the same error in my prometheus operator logs - looks like you might need to rebase this PR and change the target chart version to 45.1.1 perhaps? |
Signed-off-by: Tobias Widén <tobbetrollkarl@gmail.com> Signed-off-by: Tobias Widen <tobias.widen@tv4.se>
Signed-off-by: Tobias Widén tobbetrollkarl@gmail.com Signed-off-by: Tobias Widen <tobias.widen@tv4.se>
|
@andyspiers It's rebased now :) |
|
Confirming this solves the issue |
monotek
approved these changes
Feb 16, 2023
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…source (prometheus-community#3016) * Add permission to the alertmanagers/status resource Signed-off-by: Tobias Widén <tobbetrollkarl@gmail.com> Signed-off-by: Tobias Widen <tobias.widen@tv4.se> * Chart version 45.0.1 Signed-off-by: Tobias Widén tobbetrollkarl@gmail.com Signed-off-by: Tobias Widen <tobias.widen@tv4.se> --------- Signed-off-by: Tobias Widén <tobbetrollkarl@gmail.com> Signed-off-by: Tobias Widen <tobias.widen@tv4.se> Signed-off-by: Tobias Widén tobbetrollkarl@gmail.com
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
May 16, 2023
…source (prometheus-community#3016) * Add permission to the alertmanagers/status resource Signed-off-by: Tobias Widén <tobbetrollkarl@gmail.com> Signed-off-by: Tobias Widen <tobias.widen@tv4.se> * Chart version 45.0.1 Signed-off-by: Tobias Widén tobbetrollkarl@gmail.com Signed-off-by: Tobias Widen <tobias.widen@tv4.se> --------- Signed-off-by: Tobias Widén <tobbetrollkarl@gmail.com> Signed-off-by: Tobias Widen <tobias.widen@tv4.se> Signed-off-by: Tobias Widén tobbetrollkarl@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Version 45.0.0 introduced a bug where the monitoring-kube-prometheus-operator ClusterRole lacks the permission to alertmanagers/status.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
@andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @scottrigby @Xtigyro @QuentinBisson
Checklist
[prometheus-couchdb-exporter])