[kube-prometheus-stack] Optional Windows-specific dashboards and rules #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
lippertmarkus
requested review from
andrewgkew,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
jsturtevant
reviewed
Mar 1, 2023
Signed-off-by: Markus Lippert <markuslippert@outlook.com>
lippertmarkus
requested review from
zanhsieh,
desaintmartin,
monotek,
rsotnychenko,
dotdc,
mrueg,
tariq1890 and
a team
as code owners
Signed-off-by: Markus Lippert <markuslippert@outlook.com>
|
I don't know why it automatically added so many reviewers automatically, sorry for that |
monotek
requested changes
Mar 6, 2023
lippertmarkus
requested review from
monotek
and removed request for
zanhsieh,
desaintmartin,
rsotnychenko,
dotdc,
mrueg and
tariq1890
|
@andrewgkew @gianrubio @gkarthiks @scottrigby @Xtigyro can one of you please give us a second feedback on this? |
monotek
requested changes
Mar 20, 2023
charts/kube-prometheus-stack/templates/prometheus/rules-1.14/windows.node.rules.yaml
Outdated
Show resolved
Hide resolved
charts/kube-prometheus-stack/templates/prometheus/rules-1.14/windows.pod.rules.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
|
@jkroepke sorry was busy the last weeks. The windows-exporter chart works fine for me, thanks! I added it to the PR. |
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
|
@monotek could you please review again? |
monotek
approved these changes
Jul 3, 2023
|
@monotek and merge please :) |
This was referenced Jul 3, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Aug 25, 2023
prometheus-community#3083) * feat: add windows addon dashboards and rules Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * merge upstream Signed-off-by: Markus Lippert <markuslippert@outlook.com> * add headers Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * fix version Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * update header and add nl Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * add windows-export chart Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * spell error Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> * add NL Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> --------- Signed-off-by: Markus Lippert <lippertmarkus@gmx.de> Signed-off-by: Markus Lippert <markuslippert@outlook.com> Co-authored-by: MH <zanhsieh@gmail.com>
This was referenced Sep 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
This PR allows enabling Windows-specific dashboards and rules from kubernetes-mixin based on the kube-prometheus Windows addon. Windows nodes are widely used in Kubernetes clusters, and monitoring them should be as easy as for Linux nodes.
Special notes for your reviewer
As being an addon the dashboards and rules aren't part of the kube-prometheus
/manifestsfolder which is currently used by the hack scripts.Therefore, I generated the manifests with the addon enabled once, temporarily used those adapted manifests with the hack scripts and added the resulting new files to the PR, all gated behind
windowsMonitoring.enabled.The rules and dashboards depend on the deployment of windows_exporter like described here: https://github.com/prometheus-community/windows_exporter/blob/master/kubernetes/kubernetes.md
Checklist
[prometheus-couchdb-exporter])