[prometheus] Bump chart dependencies #3422

zeritti · 2023-05-23T22:02:24Z

What this PR does / why we need it

This PR brings the following changes:

Updates chart dependencies as follows:
- alertmanager 0.33.1
- kube-state-metrics 5.8.1 (major change)
- prometheus-node-exporter 4.18.1
- prometheus-pushgateway 2.3.0
Minor corrections in README

Which issue this PR fixes

None

Special notes for your reviewer

Included is a major (breaking) change, upgrade notes have been added.

Checklist

DCO signed
Chart Version bumped
Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

zanhsieh · 2023-05-25T06:54:02Z

charts/prometheus/README.md

+| [prometheus-pushgateway](https://github.com/prometheus-community/helm-charts/releases/tag/prometheus-pushgateway-2.1.6)   | 2.1.6 | 2.0.4 |
+
+Users are advised to review changes in the corresponding chart releases before upgrading.
+


@zeritti
do we need to provide some way to tell how to export the user current data and import to the new version?

which data should that be?

@monotek
templates/pvc.yaml, in case the user enable PVC.

@zanhsieh There is no issue related to the pushgateway's data stored in a persistent volume during the upgrade, the volume/its contents are not affected and no change on the pushgateway's side in this respect.

The same is true for Prometheus's PV - no side efects have come up in my tests.

However, whilst upgrading the pushgateway subchart with deployment and persistent volume enabled is straightforward, not so with statefulset and persistent volume - the latter cannot be patched due to changing labels and the upgrade fails. Fo this scenario, I'll have to add a note on upgrading - deleting the pushgateway's statefulset is needed before upgrading.

For prometheus-pushgateway, we should consider whether including the full label set from prometheus-pushgateway.defaultLabels (with app.kubernetes.io/version) in statefulset's spec.volmeClaimTemplates is reasonable as it leads to requiring manual intervention at an upgrade.

@zeritti
Thank you for testing that out. I think put some warning text as for pushgateway subchart sts with pvc as you suggested should be fine. We only do due diligence since in that case the user decided to go with sts - that's their choice.

charts/prometheus/README.md

monotek

Having a second look, major version update is ok, as dependency had major version update too.

The infos about this (containing lik to depnedency update notes) should be added to the upgrading section though.

alertmanager 0.33.1 kube-state-metrics 4.32.0 prometheus-node-exporter 4.18.0 prometheus-pushgateway 2.3.0 Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

Signed-off-by: André Bauer <monotek@users.noreply.github.com>

nicholascapo · 2023-06-22T17:32:04Z

charts/prometheus/Chart.lock

-  version: 4.30.0
+  version: 4.32.0


FYI, latest k-s-m is now 5.8.1

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

monotek

what @nicholascapo says.
update ksm to latest version please and raise chart version to 23.0.0

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

zeritti · 2023-06-27T11:39:34Z

what @nicholascapo says. update ksm to latest version please and raise chart version to 23.0.0

Changed, upgrade notes added

arukiidou · 2023-06-27T11:41:17Z

what @nicholascapo says. update ksm to latest version please and raise chart version to 23.0.0

Changed, upgrade notes added

Thank you! Sorry to take so your time.

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

zeritti · 2023-07-02T11:35:44Z

@monotek @zanhsieh I notice opposite views regarding upgrade notes on minor changes (b3dd332 vs 54f650f). Shall we agree on handling these?

monotek · 2023-07-03T11:35:34Z

@monotek @zanhsieh I notice opposite views regarding upgrade notes on minor changes (b3dd332 vs 54f650f). Shall we agree on handling these?

Please don't add minor update changes in the upgrading instructions.
We only add major version changes to the readmes in this repo.

It makes no sense as there is no action item for the user.
If there would be one it's a breaking / major change anyway.

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

* Bump chart dependencies alertmanager 0.33.1 kube-state-metrics 4.32.0 prometheus-node-exporter 4.18.0 prometheus-pushgateway 2.3.0 Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * remove minor version changes Signed-off-by: André Bauer <monotek@users.noreply.github.com> * Update dependencies with node exporter chart patch Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Include the latest KSM release Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Clear trailing whitespaces Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Update README file Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> --------- Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com>

zeritti marked this pull request as ready for review May 23, 2023 22:14

zeritti requested review from gianrubio, naseemkullah, Xtigyro and zanhsieh as code owners May 23, 2023 22:14

zanhsieh requested changes May 25, 2023

View reviewed changes

monotek requested changes May 26, 2023

View reviewed changes

charts/prometheus/README.md Show resolved Hide resolved

zeritti force-pushed the feat/prometheus-subcharts-bump branch 2 times, most recently from 4a573e9 to 9a74bc8 Compare May 26, 2023 12:43

zeritti marked this pull request as draft May 26, 2023 12:47

This comment was marked as resolved.

Sign in to view

monotek requested changes Jun 21, 2023

View reviewed changes

zeritti force-pushed the feat/prometheus-subcharts-bump branch from 9a74bc8 to af0bfaa Compare June 21, 2023 16:55

Bump chart dependencies

46362be

alertmanager 0.33.1 kube-state-metrics 4.32.0 prometheus-node-exporter 4.18.0 prometheus-pushgateway 2.3.0 Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

zeritti force-pushed the feat/prometheus-subcharts-bump branch from af0bfaa to 46362be Compare June 21, 2023 21:51

remove minor version changes

b3dd332

Signed-off-by: André Bauer <monotek@users.noreply.github.com>

nicholascapo reviewed Jun 22, 2023

View reviewed changes

charts/prometheus/Chart.lock Outdated

version: 4.30.0

version: 4.32.0

Copy link

Contributor

nicholascapo Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, latest k-s-m is now 5.8.1

zeritti added 2 commits June 22, 2023 18:51

Merge community/main

c4fb8e1

Update dependencies with node exporter chart patch

e5515df

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

arukiidou mentioned this pull request Jun 23, 2023

[prometheus] updates Prometheus image to 2.45.0(LTS) #3519

Merged

3 tasks

Merge branch 'main' into feat/prometheus-subcharts-bump

fca1759

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

zeritti marked this pull request as ready for review June 26, 2023 08:38

zeritti requested review from zanhsieh and monotek June 26, 2023 08:39

zanhsieh previously approved these changes Jun 26, 2023

View reviewed changes

monotek requested changes Jun 27, 2023

View reviewed changes

zeritti added 4 commits June 27, 2023 07:49

Merge community/main into feat/prometheus-subcharts-bump

24ba4b5

Include the latest KSM release

b45f0e6

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

Merge community/main into feat/prometheus-subcharts-bump

57b42f6

Clear trailing whitespaces

80c5161

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

zeritti dismissed zanhsieh’s stale review via 80c5161 June 27, 2023 11:32

zanhsieh and others added 2 commits June 28, 2023 23:00

Merge branch 'main' into feat/prometheus-subcharts-bump

9c0fe72

Update README file

31d2efe

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

Merge branch 'main' into feat/prometheus-subcharts-bump

b7c7e73

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>

monotek approved these changes Jul 3, 2023

View reviewed changes

Merge branch 'main' into feat/prometheus-subcharts-bump

a3684b4

zanhsieh approved these changes Jul 6, 2023

View reviewed changes

zanhsieh merged commit 644e23d into prometheus-community:main Jul 6, 2023
4 checks passed

zeritti deleted the feat/prometheus-subcharts-bump branch July 11, 2023 06:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[prometheus] Bump chart dependencies #3422

[prometheus] Bump chart dependencies #3422

zeritti commented May 23, 2023 •

edited

Loading

zanhsieh May 25, 2023

monotek Jun 29, 2023

zanhsieh Jun 30, 2023

zeritti Jun 30, 2023 •

edited

Loading

zanhsieh Jul 2, 2023

This comment was marked as resolved.

monotek left a comment •

edited

Loading

nicholascapo Jun 22, 2023

monotek left a comment

zeritti commented Jun 27, 2023

arukiidou commented Jun 27, 2023

zeritti commented Jul 2, 2023

monotek commented Jul 3, 2023 •

edited

Loading

		\| [prometheus-pushgateway](https://github.com/prometheus-community/helm-charts/releases/tag/prometheus-pushgateway-2.1.6) \| 2.1.6 \| 2.0.4 \|

		Users are advised to review changes in the corresponding chart releases before upgrading.

[prometheus] Bump chart dependencies #3422

[prometheus] Bump chart dependencies #3422

Conversation

zeritti commented May 23, 2023 • edited Loading

What this PR does / why we need it

Which issue this PR fixes

Special notes for your reviewer

Checklist

zanhsieh May 25, 2023

Choose a reason for hiding this comment

monotek Jun 29, 2023

Choose a reason for hiding this comment

zanhsieh Jun 30, 2023

Choose a reason for hiding this comment

zeritti Jun 30, 2023 • edited Loading

Choose a reason for hiding this comment

zanhsieh Jul 2, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

monotek left a comment • edited Loading

Choose a reason for hiding this comment

nicholascapo Jun 22, 2023

Choose a reason for hiding this comment

monotek left a comment

Choose a reason for hiding this comment

zeritti commented Jun 27, 2023

arukiidou commented Jun 27, 2023

zeritti commented Jul 2, 2023

monotek commented Jul 3, 2023 • edited Loading

zeritti commented May 23, 2023 •

edited

Loading

zeritti Jun 30, 2023 •

edited

Loading

monotek left a comment •

edited

Loading

monotek commented Jul 3, 2023 •

edited

Loading