Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom SEL events metrics #179

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

alexandrovas
Copy link

@alexandrovas alexandrovas commented Dec 27, 2023

Added a new collector to collect custom metrics from SEL events via IPMI.

In config metrics are defined in this format:

modules:
  default:
    collectors:
      ...
      - sel-events
    sel_events:
      - name: correctable_memory_error
        regex: Correctable memory error.*

Metrics are shown as:

# HELP ipmi_sel_events_count_by_state Current number of log entries in the SEL by state.
# TYPE ipmi_sel_events_count_by_state gauge
ipmi_sel_events_count_by_state{state="Nominal"} 12
ipmi_sel_events_count_by_state{state="Warning"} 128
# HELP ipmi_sel_events_count_by_name Current number of custom log entries in the SEL by name.
# TYPE ipmi_sel_events_count_by_name gauge
ipmi_sel_events_count_by_name{name="correctable_memory_error"} 140
# HELP ipmi_sel_events_latest_timestamp Latest timestamp of custom log entries in the SEL by name.
# TYPE ipmi_sel_events_latest_timestamp gauge
ipmi_sel_events_latest_timestamp{name="correctable_memory_error"} 1.704979201e+09

Closes #41

@alexandrovas alexandrovas force-pushed the feat/sel-events branch 8 times, most recently from ac06607 to 29006b4 Compare December 27, 2023 18:16
@alexandrovas
Copy link
Author

@bitfehler @SuperQ
Hello! Can you please review my PR

@SuperQ SuperQ requested a review from bitfehler January 11, 2024 11:53
@alexandrovas alexandrovas force-pushed the feat/sel-events branch 4 times, most recently from 5220dd8 to 806f3ee Compare January 12, 2024 09:18
Signed-off-by: Aleksandr Aleksandrov <aleks.aleksandrov@corp.mail.ru>
@bitfehler
Copy link
Contributor

Thanks a lot. For the record, I think we might be handing folks a decent foot-gun here, but hey 🙂

@bitfehler bitfehler merged commit d4398a6 into prometheus-community:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collect metrics from ipmi sel log
2 participants