Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jiralert docker image. #22

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Added jiralert docker image. #22

merged 1 commit into from
Mar 8, 2019

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Mar 1, 2019

Hi 👋

Docker image is must-have nowadays, so might be handy to have Dockerfile inside repo itself as Thanos and Prometheus projects have.

I would suggest setting (at later date) some docker push command to your preferred public docker registry for ease of use like here: https://github.com/improbable-eng/thanos/blob/master/Makefile#L104

In the meantime the image is available here: https://hub.docker.com/r/bplotka/jiralert/tags

Signed-off-by: Bartek Plotka bwplotka@gmail.com

Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

bwplotka commented Mar 1, 2019

And thanks for the awesome project 🍻

@free
Copy link
Member

free commented Mar 1, 2019

Thank you for contributing.

I'm still a total Docker noob, so I'll take a closer look at this, maybe try to get it to more closely match the SQL Exporter Docker configuration (which was also contributed). Or the other way around, whatever makes more sense.

@bwplotka
Copy link
Member Author

bwplotka commented Mar 1, 2019

Sure, but from my perspective keeping Dockerfile as small as possible and as tied to Prometheus as possible makes the most sense. (: But up to you.

@bwplotka
Copy link
Member Author

bwplotka commented Mar 7, 2019

@free is there any chat, email I can reach you? Would love to chat about ~4 other fixes / improvements we would love to make for "jiralert" and even help in maintaining it if you want. ((: Feel free to reach me via "bwplotka at gmail.com"

@free free merged commit 61767ce into prometheus-community:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants