Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to github actions #81

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

erdii
Copy link
Member

@erdii erdii commented Mar 5, 2021

This migrates CI from CircleCI to github actions.
The reason is: CircleCI forces users to log in and share access to their private repos to see CI logs. Github Actions doesn't.

Signed-off-by: Josh Gwosdz jgwosdz@redhat.com

Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
@erdii erdii requested a review from bwplotka March 5, 2021 17:06
@erdii
Copy link
Member Author

erdii commented Mar 5, 2021

obviously CircleCI is failing here.
I have recreated the same pr against my fork to prove that CI is working: erdii#2
@bwplotka I'd also need your help to reconfigure required status checks (throw out circleci and add gh actions)

@bwplotka
Copy link
Member

bwplotka commented Mar 5, 2021

Thanks, doing this noiw.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out!

@bwplotka bwplotka merged commit fb785a1 into prometheus-community:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants