-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish a docker image to quay for every release #86
publish a docker image to quay for every release #86
Conversation
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
@thetechnick did a small review of the pr and was concerned about security of the used secrets (rightfully so!) How do we ensure that a new PR does not dump the quay credential secrets so that the attacker can replace our images (at least until we find out)? Also: TL;DR: a PR cannot extract registry secrets :) |
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
a8a0b00
to
b944c16
Compare
registry: quay.io | ||
username: "${{ secrets.QUAY_USER }}" | ||
password: "${{ secrets.QUAY_PASS }}" | ||
- run: make docker docker-publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something like https://github.com/thanos-io/thanos/blob/main/Makefile#L5 to build from main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion (:
Intended workflow:
A new release is cut on master by creating a release and tagging it with the version
->
The build-docker workflow gets triggered and gets the version from the release tag. This also pushes the image to quay.io
Questions:
docker.io/prom/jiralert
Signed-off-by: Josh Gwosdz jgwosdz@redhat.com