Skip to content

Commit

Permalink
Remove smartmon run metric
Browse files Browse the repository at this point in the history
This metric is a bit funny, it's a timestamp per device, but it's not
accurate enough (seconds, not milliseconds) to derive much useful
information from it. This should probably be replaced with a per-device
duration metric.

Signed-off-by: SuperQ <superq@gmail.com>
  • Loading branch information
SuperQ committed May 22, 2023
1 parent b499988 commit 9552f42
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions smartmon.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,7 @@ def collect_ata_error_count(device):


def collect_disks_smart_metrics(wakeup_disks):
now = int(datetime.datetime.utcnow().timestamp())

for device in find_devices():
yield Metric('smartctl_run', device.base_labels, now)

is_active = device_is_active(device)

yield Metric('device_active', device.base_labels, is_active)
Expand Down

0 comments on commit 9552f42

Please sign in to comment.