Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bouncer): add multiple improvements such as : ignore unused pool… #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoulKyu
Copy link

@SoulKyu SoulKyu commented Feb 5, 2025

Add multiple new features such as :

  • Config file for parameters, we use systemd and with this feature the password is not in clear in the systemctl status.
  • Add a cache system with a sync every 2 min. Its permit to get a huge performance improvement by not querying pgbouncer at each scrape intervale of prometheus which is very huge when you have more than 10k pools in pgbouncer.
  • Add a parameters that permit to avoid scraping pools that are no longer used and that should be recycled at pgbouncer restart.
  • Add some improvement on the database connection.
  • Some logging which can be very usefull.

If you have any question regarding this MR we can check it together.

In term of performance we are now able to serve our prometheus server in less than 0.03sec where it was timeout before.

We now avoid to collect pools that we does not care about.

The cache system permit to not flood too much our pgbouncer and has a smarter approch.

Hope this MR will be accepted

Thanks for the huge works on this exporter

…s, caching of metrics, config file support ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant