-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint related columns in PG 17 have been moved from pg_stat_bgwriter to pg_stat_checkpointer #1072
base: master
Are you sure you want to change the base?
Checkpoint related columns in PG 17 have been moved from pg_stat_bgwriter to pg_stat_checkpointer #1072
Conversation
9f9dc26
to
40e2774
Compare
40e2774
to
b08b70d
Compare
49b1a80
to
65abcb5
Compare
Hi there! Any news? |
Ping @sysadmind |
65abcb5
to
578f4d6
Compare
@SuperQ @wrouesnel @sysadmind, could you please reiew this PR, it's important for PG17 monitoring. |
Hello, I start a very simple PG16: docker run --rm -p 5416:5432 -e POSTGRES_PASSWORD=postgres postgres:16 -d postgres I have a auth_modules:
monitoring:
type: userpass
userpass:
username: postgres
password: postgres I start the exporter (with the merged PR): ./postgres_exporter --config.file=config.yml --collector.stat_checkpointer and I call the exporter: curl 'http://localhost:9187/probe?auth_module=monitoring&target=localhost:5416/postgres?sslmode=disable' The exporter outputs this error:
I'll try to check how to improve the current PR so it can work in this mode 😄 |
Signed-off-by: Michael Todorovic <michael.todorovic@outlook.com>
ping @sysadmind @wrouesnel @SuperQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code is good and should be good to merge as soon as the Copyright dates are updated.
…iter to pg_stat_checkpointer Fix prometheus-community#1060 See: https://www.dbi-services.com/blog/postgresql-17-new-catalog-view-pg_stat_checkpointer/ Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>
See: https://www.dbi-services.com/blog/postgresql-17-new-catalog-view-pg_stat_checkpointer/ Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>
Signed-off-by: Nicolas Rodriguez <nico@nicoladmin.fr>
578f4d6
to
8a9f10c
Compare
👋 @n-rodriguez , would you please check the changes in n-rodriguez#1? |
Fix #1060
See:
Thank you!