Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Update windows buffer size #110

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

ken-schneider
Copy link
Contributor

This addresses #34

@olljanat
Copy link

olljanat commented Jul 6, 2024

@ken-schneider looks that your commits are missing signing (DCO). Guidance here is not too good so look example https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work what it means and how to do it.

Signed-off-by: Ken Schneider <ken.schneider@datadoghq.com>
Signed-off-by: Ken Schneider <ken.schneider@datadoghq.com>
@ken-schneider
Copy link
Contributor Author

@olljanat thanks for pointing that out. Just amended the commit messages to include my sign off

@ken-schneider
Copy link
Contributor Author

@olljanat @SuperQ @metalmatze would one of you mind having a look at this PR when you have a chance?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@SuperQ SuperQ merged commit 01c023c into prometheus-community:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants