Set outbound interface, like ping -I option
#32
Conversation
ilolicon
changed the title
ping -I optionping -I option
|
This needs a DCO sign-off. You can use |
ping.go
Outdated
| // Iface used to send/recv ICMP messages | ||
| Iface string |
There was a problem hiding this comment.
I don't like the short name
| // Iface used to send/recv ICMP messages | |
| Iface string | |
| // Interface used to send/recv ICMP messages | |
| Interface string |
There was a problem hiding this comment.
The original intention was just to avoid confusion with the go interface keyword
There was a problem hiding this comment.
Maybe InterfaceName then if needed?
There was a problem hiding this comment.
I adopted Interface to make a new commit but the ci test still fails
I use the same ci docker image locally and it works fine. Am I doing something wrong?
I hope you can give me some help, thank you very much
circleci@3b386f984da0:~/project/pro-bing$ git branch -vv
* feature-interface-binding 60b7449 [origin/feature-interface-binding] Refactoring the variable name `Iface` to `Interface` and `ifaceIndex` to `ifIndex`(keeping it consistent with `ControlMessage`)
main a17ba03 [origin/main] Merge pull request #29 from TheRushingWookie/add_context
circleci@3b386f984da0:~/project/pro-bing$ make style vet test
>> checking code style
>> vetting code
GO111MODULE= go vet ./...
>> running all tests
GO111MODULE= go test -race -cover ./...
ok github.com/prometheus-community/pro-bing (cached) coverage: 76.9% of statements
? github.com/prometheus-community/pro-bing/cmd/ping [no test files]ci error message: socket: permission denied
Signed-off-by: ilolicon <97431110@qq.com>
… to `ifIndex`(keeping it consistent with `ControlMessage`) Signed-off-by: ilolicon <97431110@qq.com>
ilolicon
force-pushed
the
feature-interface-binding
branch
from
8dffa7b
to
60b7449
Compare
| @@ -29,6 +29,9 @@ Examples: | |||
| # ping google for 10 seconds | |||
| ping -t 10s www.google.com | |||
|
|
|||
| # ping google specified interface | |||
| ping -I eth1 www.goole.com | |||
There was a problem hiding this comment.
| ping -I eth1 www.goole.com | |
| ping -I eth1 www.google.com |
|
FWIW, I would like to see this feature added in order to use VRF with this library. |
|
I need this feature really bad. Can anyone merge this? |
|
The PR needs to be rebased if it is to have any chance of getting merged. |
Hello,
I attempted to implement a useful feature - sending data packets from a specific network interface, similar to what the "ping" command's "-I" option does in Linux.
Hoping I did it correctly. Test successfully passed on Linux OS.
Thanks!
The issues related to this feature:
go-ping/ping#111
go-ping/ping#204