This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks relative to before #486. The extremely slow case is still fixed, and some fairly fast cases get a little slower. I do have ideas for further optimisations.
|
10f171a
to
d520618
Compare
d520618
to
1b9cbaa
Compare
1b9cbaa
to
21fee27
Compare
Updated. |
926e856
to
709fe89
Compare
d21ddd3
to
ccbe84b
Compare
Use a heap for Next for merges, and pre-compute if there's many postings on the unset path. Add posting lookup benchmarks Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
ccbe84b
to
d6a81d9
Compare
LGTM, thanks Brian! |
bwplotka
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -354,11 +354,23 @@ func postingsForUnsetLabelMatcher(ix IndexReader, m labels.Matcher) (index.Posti | |||
rit = append(rit, it) | |||
} | |||
|
|||
merged := index.Merge(rit...) | |||
// With many many postings, it's best to pre-calculate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ping for me to update Thanos code as well: https://github.com/improbable-eng/thanos/blob/master/pkg/store/bucket.go#L1249
Merged
mikkeloscar
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 7, 2019
Use a heap for Next for merges, and
pre-compute if there's many postings on the
unset path.
Add posting lookup benchmarks
Signed-off-by: Brian Brazil brian.brazil@robustperception.io
Fixes prometheus/prometheus#5173
FYI @jacksontj @bwplotka