Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Set path.udev.data Argument of Node Exporter #1913

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

raptorsun
Copy link
Contributor

Description

This PR fix a bug in the node-exporter daemon set that it cannot open the /run/udev/data path.
Example error log from node-exporter pods:

ts=2022-10-21T15:55:50.349Z caller=diskstats_linux.go:264 level=error collector=diskstats msg="Failed to open directory, disabling udev device properties" path=/run/udev/data

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

Fix a bug in Node Exporter that diskstat collector cannot open the /run/udev/data path.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@paulfantom
Copy link
Member

Thank you and sorry for delay in review.

@dss010101
Copy link

this is kind of hold, but figured i'd ask..trying to monitor an old amazon ami (2018) linux...doesnt seem to be any such path /run/udev.
what to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants