Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot] [main] Automated version update #2408

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

prom-op-bot
Copy link
Contributor

@prom-op-bot prom-op-bot commented Apr 22, 2024

Description

This is an automated version and jsonnet dependencies update performed from CI.

Please review the following changelogs to make sure that we don't miss any important
changes before merging this PR.

https://github.com/grafana/grafana/releases/tag/v10.4.2 https://github.com/prometheus/node_exporter/releases/tag/v1.8.0 https://github.com/prometheus/prometheus/releases/tag/v2.52.0 https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.73.2 https://github.com/brancz/kube-rbac-proxy/releases/tag/v0.17.1

Configuration of the workflow is located in .github/workflows/versions.yaml.

Type of change

  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry


@prom-op-bot prom-op-bot requested a review from a team April 22, 2024 07:40
@kakkoyun
Copy link
Member

@metalmatze I think something has changed in node-mixin, and e2e tests are failing, no?

@rgarcia89
Copy link
Contributor

@kakkoyun I don't see any other tests failing besides the security run. However, these tests have been failing for quite some time now. So, in general, they shouldn't be related to this PR

@philipgough
Copy link
Contributor

hey sorry for the lag on this. yeah I think this is fine. merging

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philipgough philipgough merged commit 2a07e45 into main May 13, 2024
18 of 20 checks passed
@philipgough philipgough deleted the automated-updates-main branch May 13, 2024 07:58
@kakkoyun
Copy link
Member

Something must have changed. Thanks to whoever fixed it 🎉

@rgarcia89
Copy link
Contributor

rgarcia89 commented May 13, 2024

Careful with the update to prometheus v2.52.0. I am seeing the following since the update in the logs which is triggering the PrometheusDuplicateTimestamps rule.

ts=2024-05-13T09:06:22.827Z caller=scrape.go:1738 level=warn component="scrape manager" scrape_pool=serviceMonitor/monitoring/kube-state-metrics/0 target=https://10.244.1.208:8443/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=1
ts=2024-05-13T09:06:52.930Z caller=scrape.go:1738 level=warn component="scrape manager" scrape_pool=serviceMonitor/monitoring/kube-state-metrics/0 target=https://10.244.1.208:8443/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=1

Downgrading to prometheus v2.51.2 fixed it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants