Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest version by tag if no release exists #2435

Merged
merged 2 commits into from
May 30, 2024

Conversation

rgarcia89
Copy link
Contributor

Description

The https://github.com/jimmidyson/configmap-reload project is no longer generating releases. As a result, we are still using version 0.5.0, which contains several vulnerabilities, while version 0.13.0 has been released as a tag. Additionally, the image location has changed from Docker Hub to GitHub.

I have added a section to the generate version script to obtain the latest tag if no release is generated. Furthermore, I have updated the image location accordingly.

Type of change

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Get latest version by tag if not release exists

Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
Signed-off-by: Raul Garcia Sanchez <info@raulgarcia.de>
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks

@philipgough philipgough merged commit d3fa80e into prometheus-operator:main May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants