blackbox-exporter: fix broken image reference #2439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently used version of the configmap-reload image (0.5.0) isn't hosted on Github (ghcr.io/jimmidyson/configmap-reload), only on Docker Hub (jimmidyson/configmap-reload), meaning the current reference is broken. Only the versions from 0.10.0 and onwards are hosted on Github. The best long term solution would be to bump configmap-reload to a newer version, but this is something I'm not comfortable doing.
|
Never mind, problem was fixed by bumping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Fixes a broken reference to the
configmap-reloadimage.The currently used version of the
configmap-reloadimage (0.5.0) isn't hosted on Github (ghcr.io/jimmidyson/configmap-reload), only on Docker Hub (jimmidyson/configmap-reload). Only the versions from0.10.0and onwards are hosted on Github (as described in the repository's readme).The best long term solution would be to bump configmap-reload to a newer version, but this is something I'm not comfortable doing.
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.