Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Client Lib to API v2? #2762

Closed
sinkingpoint opened this issue Nov 9, 2021 · 3 comments
Closed

Upgrading Client Lib to API v2? #2762

sinkingpoint opened this issue Nov 9, 2021 · 3 comments

Comments

@sinkingpoint
Copy link
Contributor

What did you do?

Used the client library in this repo (https://github.com/prometheus/alertmanager/blob/main/client/client.go)

What did you expect to see?

It use the v2 api

What did you see instead? Under which circumstances?

It's hardcoded to use the v1 api (https://github.com/prometheus/alertmanager/blob/main/client/client.go#L32)

Is this maintained? I note that it hasn't been touched in a year and a bit. Considering the expected deprecation of the v1 api we should probably update it or deprecate it along with the API (I would be in favour of the former)

@roidelapluie
Copy link
Member

@roidelapluie
Copy link
Member

Would you send a PR to remove the v1 client?

@sinkingpoint
Copy link
Contributor Author

Ah. Good to know. Yes sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants