Remove v1 client lib #2763
Merged
Remove v1 client lib #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkingpoint
force-pushed
the
sinkingpoint/remove_v1_client
branch
4 times, most recently
from
24b6cc9 to
effada6
Compare
|
Erk... This seems to be more ingrained than I anticipated. Not sure whether we want to do this @roidelapluie considering this might have a bit of an impact |
|
This is indeed used in the acceptance tests. What about we move client and client_test.go inside test/with_api_v1/acceptance.go and merge them into a file called helper_test.go ? test/with_api_v1/acceptance.go |
|
Sounds reasonable. The source of this confusion comes from the prominence of this lib in the repo, so moving this out of that location makes sense |
sinkingpoint
force-pushed
the
sinkingpoint/remove_v1_client
branch
from
effada6 to
f507e12
Compare
|
Build error looks transient? |
sinkingpoint
force-pushed
the
sinkingpoint/remove_v1_client
branch
2 times, most recently
from
96e4575 to
d182c98
Compare
This commit moves the stuff formerly in /client into /test/with_api_v1 so that we can discourage use of the v1 client without breaking things Signed-off-by: sinkingpoint <colin@quirl.co.nz>
sinkingpoint
force-pushed
the
sinkingpoint/remove_v1_client
branch
from
d182c98 to
96bc0fb
Compare
|
Fixed this. Yet again, the build failures appear to be docker pull timeouts which is weird |
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is confusing as it sits in the root of the repo. Considering we
have a v2 client lib at (https://github.com/prometheus/alertmanager/blob/main/api/v2/client/alertmanager_client.go) this commit removes the v1 one to try and avoid
that confusion
Solves #2762