notify/pagerduty: Filter out empty images and links #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PagerDuty Event API v2 [1] requires images to have an `src` property, and links to have an `href` property. This commit filters out images and links that don't satisfy those conditions, to avoid getting an HTTP 400 error in response. This also adds flexibilty when using templates to configure images and links, as it's now possible to omit images or links by letting the template return an empty string for the `src` or `href` property, respectively. [1]: https://developer.pagerduty.com/docs/events-api-v2/trigger-events/#context-properties Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
|
Hey! Just ran into this one. Any chance of getting this into a release? /cc @simonpasquier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PagerDuty Event API v2 1 requires images to have an
srcproperty, and linksto have an
hrefproperty.This commit filters out images and links that don't satisfy those conditions,
to avoid getting an HTTP 400 error in response.
This also adds flexibilty when using templates to configure images and links,
as it's now possible to omit images or links by letting the template return an
empty string for the
srcorhrefproperty, respectively.Signed-off-by: Benoît Knecht bknecht@protonmail.ch