Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting favicon.ico dinamically #2392

Merged
merged 2 commits into from
Oct 15, 2020
Merged

setting favicon.ico dinamically #2392

merged 2 commits into from
Oct 15, 2020

Conversation

Sprootsy
Copy link
Contributor

Refers to #2323

@roidelapluie
Copy link
Member

This seems fragile and complex.

Did you try <link rel="icon" href="favicon.ico" /> (using a relative path?)

@Sprootsy
Copy link
Contributor Author

This seems fragile and complex.

Did you try <link rel="icon" href="favicon.ico" /> (using a relative path?)

Yeah I thought it was pretty bad too :)
I didn't know it was an option. I'll try that.

@Sprootsy
added favico link with relative path
a61acaf 
Signed-off-by: jberny <f.bernardi89@gmail.com>
@simonpasquier
Copy link
Member

LGTM. Can you run make assets and commit the changes?

@Sprootsy
re-generated assets
d09c8c3 
Signed-off-by: jberny <f.bernardi89@gmail.com>
@Sprootsy
Copy link
Contributor Author

When i run make assets i notice that all files api/v2/* are deleted. I didn't think that's ok, so i just commited the changes to asset/assets_vfsdata.go

@simonpasquier
Copy link
Member

All good, thanks!

@simonpasquier simonpasquier merged commit 00b86d9 into prometheus:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sprootsy @roidelapluie @simonpasquier