Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notify/victorops): Catch routing_key templating errors #2467

Merged
merged 2 commits into from
Jan 29, 2021
Merged

fix(notify/victorops): Catch routing_key templating errors #2467

merged 2 commits into from
Jan 29, 2021

Conversation

jdbaldry
Copy link
Contributor

The error used during the templating of the routing key is not checked before it is later reassigned.

@jdbaldry
test(notify/victorops): Add test for templating errors
f9a70c4 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
fix(notify/victorops): Catch routing_key templating errors
3311106 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
simonpasquier
simonpasquier approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit bf94d58 into prometheus:master Jan 29, 2021
@jdbaldry jdbaldry deleted the victorops-template-validation branch February 1, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdbaldry @simonpasquier