-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth 2.0 Config #2560
Add OAuth 2.0 Config #2560
Conversation
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
### `oauth2` | ||
|
||
OAuth 2.0 authentication using the client credentials grant type. | ||
Alertmanager fetches an access token from the specified endpoint with | ||
the given client access and secret keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that in Prometheus I put oauth2
after tls_config
, but given that oauth2
goes along with the other authentication methods and is therefore first, and decided to put it ahead of tls_config
here like it's supposed to. That being said, it does make the ordering inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tls_config also contains authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, although the order in common has OAuth 2.0 first anyways. I'm probably making too big of a deal out of this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In prometheus we could reorder everything because the order is messy overall.
In common we could split some of them into separated files.
v0.22.2 * tag 'v0.22.2': (181 commits) Release 0.22.2 Include pending silences for future muting decisions Release 0.22.1 Default the isEqual flag to true in alertmanager Add test to expose issue prometheus#2426 Release alertmanager 0.22 Relase 0.22.0-rc.2 API: Only pass cluster peer if empty fixed small typo Release 0.22.0-rc.1 Fix panic when HA is disabled Update matcher examples Add prometheus#2276 to release notes Release 0.22.0-rc.0 Lift moratorium on AlertManager receivers with long-term maintenance plan (prometheus#2561) Add OAuth 2.0 Config (prometheus#2560) Add missing EOL Fix flapping acceptance test Unlock at specific points instead of deferring Dispatch: Make sure mutex gets unlocked on call to Stop ...
This PR upgrades the common version so that OAuth 2.0 is supported and properly documents the config.
cc @roidelapluie