Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTF-8 label matchers: Update the docs on how to use UTF-8 in label matchers and parse mode feature flags #3572

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Support UTF-8 label matchers: Update the docs on how to use UTF-8 in label matchers and parse mode feature flags #3572

merged 7 commits into from
Feb 14, 2024

Conversation

grobinson-grafana
Copy link
Contributor

This pull request updates the docs to:

  1. Explain that there is a new parser for label matchers, the transition period, and how Alertmanager reverts to the classic parser.
  2. How to use the feature flags to switch between fallback, UTF-8, and classic parse modes.
  3. The difference between UTF-8 matchers and classic matchers.
  4. Improved the documentation on composing matchers to make more complex expressions.

@grobinson-grafana grobinson-grafana changed the title Update the docs on how to use UTF-8 in label matchers and parse mode feature flags Support UTF-8 label matchers: Update the docs on how to use UTF-8 in label matchers and parse mode feature flags Oct 26, 2023
@grobinson-grafana grobinson-grafana force-pushed the grobinson/update-docs-utf8-matchers branch from 8ff2419 to 572d9d5 Compare January 16, 2024 21:33
gotjosh
gotjosh reviewed Feb 13, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Show resolved Hide resolved
@grobinson-grafana grobinson-grafana force-pushed the grobinson/update-docs-utf8-matchers branch from 2b6780c to 859e59b Compare February 13, 2024 14:20
gotjosh
gotjosh approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Beautiful, thank you very much for the documentation improvement .

docs/configuration.md Outdated Show resolved Hide resolved
@grobinson-grafana
Update the docs on how to use UTF-8 in label matchers and parse mode …
36f3a28 
…feature flags

Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Update configuration.md as feature flags renamed
4b432e4 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Add docs for modes
72a67d5 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Update grammar
3cdb8d6 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Feedback
f35184e 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Feedback
2179e3f 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana
Fix grammar
241acea 
Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana grobinson-grafana force-pushed the grobinson/update-docs-utf8-matchers branch from 4932d02 to 241acea Compare February 14, 2024 09:12
@grobinson-grafana
Copy link
Contributor Author

I rebased main.

@gotjosh gotjosh merged commit c2cf3db into prometheus:main Feb 14, 2024
11 checks passed
grobinson-grafana added a commit to grafana/mimir that referenced this pull request Feb 14, 2024
@grobinson-grafana
Alertmanager: Update Alertmanager to commit d352d16
b20b455 
This commit updates Alertmanager from f69a508 to d352d16.
It has the following changes:

- prometheus/alertmanager#3565
- prometheus/alertmanager#3718
- prometheus/alertmanager#3707
- prometheus/alertmanager#3719
- prometheus/alertmanager#3592
- prometheus/alertmanager#3572
- prometheus/alertmanager#3722
@grobinson-grafana grobinson-grafana mentioned this pull request Feb 14, 2024
Merged
4 tasks
gotjosh pushed a commit to grafana/mimir that referenced this pull request Feb 15, 2024
@grobinson-grafana
Alertmanager: Update Alertmanager to commit 80b3cb0 (#7384)
1ae1641 
* Alertmanager: Update Alertmanager to commit d352d16

This commit updates Alertmanager from f69a508 to d352d16.
It has the following changes:

- prometheus/alertmanager#3565
- prometheus/alertmanager#3718
- prometheus/alertmanager#3707
- prometheus/alertmanager#3719
- prometheus/alertmanager#3592
- prometheus/alertmanager#3572
- prometheus/alertmanager#3722
th0th pushed a commit to th0th/alertmanager that referenced this pull request Mar 23, 2024
@grobinson-grafana @th0th
Support UTF-8 label matchers: Update the docs on how to use UTF-8 in …
a412889 
…label matchers and parse mode feature flags (prometheus#3572)

* Update the docs on how to use UTF-8 in label matchers and parse mode feature flags

Signed-off-by: George Robinson <george.robinson@grafana.com>
---------

Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: Gokhan Sari <gokhan@sari.me>
@grobinson-grafana grobinson-grafana deleted the grobinson/update-docs-utf8-matchers branch April 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotjosh gotjosh gotjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @gotjosh