Support UTF-8 label matchers: Update Stringer for non-Prometheus compliant label names #3580
Conversation
grobinson-grafana
force-pushed
the
grobinson/update-matcher-stringer
branch
from
689b3c2 to
1dd19e6
Compare
| // matchers. Until then, the classic parser does not understand double quotes | ||
| // around the label name, so we use this function as a heuristic to tell if | ||
| // the matcher was parsed with the UTF-8 parser or the classic parser. | ||
| func isReserved(r rune) bool { |
There was a problem hiding this comment.
I'm assuming making the function public and re-using it here was a no-go for some reason?
I'd love if we could please keep track of these tidbits that we need to remove once we're done.
There was a problem hiding this comment.
It's a bit of an odd one I think. Remember how we made the lexer and all it's related functions package-private? It felt weird to me that we would expose this one function that checks for reserved characters when the rest of the lexer and it's related functions are inaccessible.
Besides, I'm thinking we'll delete this once we removed the old parser so I felt it was cleaner to duplicate it and add a comment.
There was a problem hiding this comment.
Remember how we made the lexer and all it's related functions package-private? It felt weird to me that we would expose this one function
I think a comment may do the trick to signal that this function is going away as this is temporary anyway, but I'm fine either way now that is properly tracked in the main epic.
This commit updates the String method to print non-Prometheus compliant label names in a format that can be parsed in the UTF-8 parser. Such inputs are never valid in the classic parser. If the label name is Prometheus compliant, it is still printed unquoted. Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/update-matcher-stringer
branch
from
1dd19e6 to
f076c89
Compare
This commit updates the String method to print non-Prometheus compliant label names in a format that can be parsed in the UTF-8 parser. Such inputs are never valid in the classic parser. If the label name is Prometheus compliant, it is still printed unquoted.