Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace incorrect use of fmt.Errorf #3883

Merged

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jun 18, 2024

This commit replaces incorrect use of fmt.Errorf with errors.New in silence.go.

Copy link
Contributor

@TheMeier TheMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing test is the known flaky one

This commit replaces incorrect use of fmt.Errorf with errors.New
in silence.go.

Signed-off-by: George Robinson <george.robinson@grafana.com>
@grobinson-grafana grobinson-grafana force-pushed the grobinson/replace-fmt-with-errors branch from 893ca72 to 1493a38 Compare June 18, 2024 13:41
@grobinson-grafana
Copy link
Contributor Author

failing test is the known flaky one

Thanks! I force pushed to restart it 😄

@gotjosh gotjosh merged commit db32fab into prometheus:main Jun 20, 2024
11 checks passed
grobinson-grafana added a commit to grobinson-grafana/alertmanager that referenced this pull request Jun 20, 2024
@grobinson-grafana grobinson-grafana deleted the grobinson/replace-fmt-with-errors branch June 25, 2024 15:59
TheMeier pushed a commit to TheMeier/alertmanager that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants