Log errors from probe #1091
Merged
Log errors from probe #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
log-probe-errors
branch
from
eca74da to
f509c4f
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
force-pushed
the
log-probe-errors
branch
from
f509c4f to
d381716
Compare
SuperQ
previously requested changes
Jul 1, 2023
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
|
@electron0zero Could you please also take a look here? |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
force-pushed
the
log-probe-errors
branch
from
7643270 to
a47ca22
Compare
electron0zero
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
lgtm, will wait for @roidelapluie or @mem to take a look and approve :)
|
@electron0zero @roidelapluie or @mem How we can proceed here? |
|
assuming that there are no comments or feedback from other maintainers, I am going to go ahead and merge it. |
hatamiarash7
pushed a commit
to hatamiarash7/blackbox_exporter
that referenced
this pull request
Aug 27, 2023
* Log errors from probe Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * Update main.go Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> * Implement --log.prober Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Arash Hatami <hatamiarash7@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
--log.proberwhich can be one of: [debug, info, warn, error, none] to investigate probe failures port-mortem. this flag defaults to none.At the moment, this analyse problems is only possible via Web UI with an large enough history. Access the unprotected web ui can be difficult and the probe history is only available until restart.